Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

model: avoid setting value on getter #465

Merged
merged 1 commit into from
Nov 9, 2023
Merged

model: avoid setting value on getter #465

merged 1 commit into from
Nov 9, 2023

Conversation

jrcastro2
Copy link
Contributor

@slint slint merged commit 6c74274 into inveniosoftware:master Nov 9, 2023
8 checks passed
kpsherva
kpsherva reviewed Nov 10, 2023
View reviewed changes
invenio_accounts/models.py
@@ -239,7 +239,7 @@ def preferences(self):
if self._preferences is None:
return None
elif not isinstance(self._preferences, UserPreferenceDict):
self._preferences = UserPreferenceDict(**self._preferences)
return UserPreferenceDict(**self._preferences)

return self._preferences
Copy link
Contributor

@kpsherva kpsherva Nov 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line of code becomes unreachable, please remove it sorry didn't notice it was elif before, ignore the comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpsherva kpsherva kpsherva left review comments

@slint slint slint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrcastro2 @slint @kpsherva